[fix] Support Android Studio path that JetBrains Toolbox installs to on Windows #2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath than the one detected by doctor. Support this alternate path for folks who aren't using nuget to install Android Studio.
matthargett
requested review from
cipolleschi,
thymikee and
szymonrybczak
as code owners
thymikee
reviewed
Jul 7, 2025
thymikee
reviewed
Jul 7, 2025
thymikee
reviewed
Jul 7, 2025
| environmentInfo.IDEs['Android Studio'] = 'Not Found'; | ||
| // Force the platform to win32 for the test | ||
| const platformSpy = jest | ||
| .spyOn(process, 'platform', 'get') |
There was a problem hiding this comment.
tests are failing here, can you investigate that?
…dows-android-studio-path
…, so inject a writable propery for the test. there is a slightly nicer way to do this in jest 29+ with 'replaceProperty', I added some TODO comments as a reminder when someone upgrades jest later.
…cli into windows-android-studio-path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default experience on Windows has a few issues, and this one is an easy fix. Jetbrains Toolbox and the default Android Studio user installer install into a path that the
doctorcommand doesn't look in. This causes doctor to install yet another Android Studio unnecessarily.Test Plan
CLI now detects the Android Studio installation on my Windows 11 machine.
Added a unit test to show the fallback path is working.
Checklist
react-nativecheckout (instructions).